Skip to content

feat: add table component#79

Merged
pruthvi2103 merged 3 commits intoantstackio:mainfrom
hafsahayath:components/table
Sep 1, 2022
Merged

feat: add table component#79
pruthvi2103 merged 3 commits intoantstackio:mainfrom
hafsahayath:components/table

Conversation

@hafsahayath
Copy link
Copy Markdown
Contributor

@hafsahayath hafsahayath commented Aug 30, 2022 •
edited
Loading

Description

  • Adds table component to the library

How Has This Been Tested?

  • tested it in the examples folder.

Screenshots (if appropriate):

  • basic table

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

closes #48

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 30, 2022 •
edited
Loading

✅ Deploy Preview for hover-design canceled.

Name Link
🔨 Latest commit b966fe0
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/631062d91ca12a0008685270

@hafsahayath hafsahayath self-assigned this Aug 30, 2022
@hafsahayath hafsahayath added this to the v0.1.8-alpha milestone Aug 30, 2022
pruthvi2103
pruthvi2103 suggested changes Sep 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Comments

Comment thread lib/src/components/Table/Table.css.ts Outdated
Comment thread lib/src/components/Table/Table.css.ts Outdated
Comment thread lib/src/components/Table/Table.tsx
Comment thread lib/src/components/Table/TableCaption/TableCaption.tsx Outdated
Comment thread lib/src/components/Table/Table.tsx Outdated
Comment thread lib/src/components/Table/Td/Td.tsx Outdated
Comment thread lib/src/components/Table/Tfoot/Tfoot.tsx Outdated
Comment thread lib/src/components/Table/Thead/Thead.css.ts Outdated
Comment thread lib/src/components/Table/Thead/Thead.tsx Outdated
Comment thread lib/src/components/Table/Thead/Thead.tsx Outdated
pruthvi2103
pruthvi2103 approved these changes Sep 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome work!!

@pruthvi2103
Copy link
Copy Markdown
Contributor

pruthvi2103 commented Sep 1, 2022

I've approved the PR. Do you want to create a separate PR for documentation? Or will you work on this?

@hafsahayath
Copy link
Copy Markdown
Contributor Author

hafsahayath commented Sep 1, 2022

I've approved the PR. Do you want to create a separate PR for documentation? Or will you work on this?

I will create a separate PR for documentation, please merge this

@pruthvi2103 pruthvi2103 merged commit 4971bb9 into antstackio:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Raalzz Raalzz Awaiting requested review from Raalzz

1 more reviewer

@pruthvi2103 pruthvi2103 pruthvi2103 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hafsahayath hafsahayath

Labels

None yet

Projects

None yet

Milestone

v0.1.8-alpha

Development

Successfully merging this pull request may close these issues.

Table Component

2 participants

@hafsahayath @pruthvi2103