Merged
Conversation
✅ Deploy Preview for hover-design ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pruthvi2103
suggested changes
Aug 30, 2022
Contributor
pruthvi2103
left a comment
pruthvi2103
left a comment
There was a problem hiding this comment.
Looks like tab navigation gets stuck at Tabs and one cant escape out of it. Please fix this as it breaks any accessibility that other elements have
pruthvi2103
approved these changes
Sep 1, 2022
Contributor
pruthvi2103
left a comment
pruthvi2103
left a comment
There was a problem hiding this comment.
LGTM. Please add a tech debt on jira to make keyboard specific utilities. Also pl get the docs preview up
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tabs v2
Description
Added
Motivation and Context
Enhancement to existing Tabs Component
How Has This Been Tested?
Local build successful and manually tested
Screenshots (if appropriate):
Types of changes
Checklist: