Merged
Conversation
✅ Deploy Preview for hover-design ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
pl fill the PR template too 🥲 |
Closed
3 tasks
pruthvi2103
suggested changes
Aug 18, 2022
Contributor
pruthvi2103
left a comment
pruthvi2103
left a comment
There was a problem hiding this comment.
Some minor nitpicks, apart from that the component looks Awesome!!!
there are items that can be taken up for v2 of tabs, please create an issue of the things we plan to pickup when we develop v2 of tabs. Also one of the main things for v2 should be accessibility (the tabs cant be used with keyboard navigation)
Contributor
|
Pl resolve conflicts too |
pruthvi2103
approved these changes
Aug 19, 2022
Contributor
pruthvi2103
left a comment
pruthvi2103
left a comment
There was a problem hiding this comment.
LGTM! Great Work 💯
Pl just comment the issue #s here too so that we know they are connected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tab Component