Skip to content

HOV-15 | TextArea Component #51

Merged
pruthvi2103 merged 13 commits intomainfrom
textarea-component
Aug 18, 2022
Merged

HOV-15 | TextArea Component #51
pruthvi2103 merged 13 commits intomainfrom
textarea-component

Conversation

@Shadow-Flash
Copy link
Copy Markdown
Contributor

@Shadow-Flash Shadow-Flash commented Aug 6, 2022

Description

  • TextArea Component with all built-in functionality.
  • Didn't use input with type=text rather used the Textarea tag Check This.
  • HOV number will updated as soon as I get.
  • This pull request is to check the progress of current issue HOV-15 | Textarea Component #40 .

Motivation and Context

How Has This Been Tested?

Tested locally on vanilla-extract-example folder App.tsx file.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 6, 2022

Deploy Preview for hover-design ready!

Name Link
🔨 Latest commit 8b3fc86
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/62fda7d4189ffe0008aaf04b
😎 Deploy Preview https://deploy-preview-51--hover-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. The whole structure looks good, need to just tailor it in such a way that the component fits into any project which look extremely different

Great work!

Comment thread lib/src/components/TextArea/text-area.types.ts Outdated
Comment thread lib/src/components/TextArea/TextArea.tsx Outdated
Comment thread lib/src/components/TextArea/text-area.css.ts Outdated
Comment thread lib/src/components/TextArea/TextArea.tsx Outdated
Comment thread lib/src/components/TextArea/TextArea.tsx Outdated
@Shadow-Flash Shadow-Flash changed the title [HOV] TextArea Component [HOV-15] TextArea Component Aug 6, 2022
@Shadow-Flash Shadow-Flash changed the title [HOV-15] TextArea Component HOV-15 | TextArea Component Aug 6, 2022
Comment thread docs/docs/components/text-area.mdx Outdated
Comment thread lib/src/components/TextArea/text-area.css.ts Outdated
Comment thread lib/src/components/TextArea/TextArea.tsx
@Raalzz Raalzz added this to the v0.1.7-alpha milestone Aug 12, 2022
@pruthvi2103 pruthvi2103 added the New Component Addition of new Components label Aug 18, 2022
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome work!

@pruthvi2103 pruthvi2103 merged commit 521d2b4 into main Aug 18, 2022
@pruthvi2103 pruthvi2103 linked an issue Aug 18, 2022 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Component Addition of new Components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HOV-15 | Textarea Component

3 participants