Skip to content

[HOV-10] Flex component#25

Merged
pruthvi2103 merged 18 commits intomainfrom
flex-component
Aug 6, 2022
Merged

[HOV-10] Flex component#25
pruthvi2103 merged 18 commits intomainfrom
flex-component

Conversation

@Shadow-Flash
Copy link
Copy Markdown
Contributor

@Shadow-Flash Shadow-Flash commented Aug 3, 2022

Description

New flex component with all the major flex properties included.

Motivation and Context

Mainly it will handle all the flex styling with cross origin styling using all the flex properties.

How Has This Been Tested?

Added in Docusaurus and tested

Screenshots (if appropriate):

image

Todo's

  • flex properties namely
    • flexGrow
    • flexBasis
  • Need to pass ref prop into div in flex.ts component
  • Documentation is still not completed, it needs an in-depth explanation for each major heading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 3, 2022

Deploy Preview for hover-design canceled.

Name Link
🔨 Latest commit 145157e
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/62ecd283d0d7e300089282ed

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 3, 2022

Deploy Preview for cheerful-crostata-e27410 ready!

Name Link
🔨 Latest commit 0354049
🔍 Latest deploy log https://app.netlify.com/sites/cheerful-crostata-e27410/deploys/62eb69dab1c9090008869be1
😎 Deploy Preview https://deploy-preview-25--cheerful-crostata-e27410.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Shadow-Flash Shadow-Flash added the New Component Addition of new Components label Aug 3, 2022
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

Comment thread examples/vanilla-extract-react/package.json Outdated
@pruthvi2103 pruthvi2103 mentioned this pull request Aug 4, 2022
6 tasks
@pruthvi2103 pruthvi2103 linked an issue Aug 4, 2022 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!!

Comment thread lib/src/components/Flex/Flex.tsx
@pruthvi2103 pruthvi2103 added this to the v0.1.7-alpha milestone Aug 6, 2022
@pruthvi2103
Copy link
Copy Markdown
Contributor

LGTM, even styles appear to be working well! merging

@pruthvi2103 pruthvi2103 merged commit 60ff9f3 into main Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Component Addition of new Components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HOV-10 | Flex Component

2 participants