Skip to content

HOV-3 - Adds Badge Component [V1] #16

Merged
pruthvi2103 merged 5 commits intomainfrom
badge-component
Jul 13, 2022
Merged

HOV-3 - Adds Badge Component [V1] #16
pruthvi2103 merged 5 commits intomainfrom
badge-component

Conversation

@Raalzz
Copy link
Copy Markdown
Member

@Raalzz Raalzz commented Jul 5, 2022

Description

Adds a Badge Component to the hover design library.

Motivation and Context

The badge component is a tiny count and labelling component. It is highly customisable, Can also accepts any JSX element.

How Has This Been Tested?

Added in Docusaurus and tested

Screenshots (if appropriate):

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hover-design ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 6:32PM (UTC)

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 5, 2022

Deploy Preview for hover-design failed.

Name Link
🔨 Latest commit ba02663
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/62cdbe04e3c8ec0008628fd4

@Raalzz Raalzz changed the title feat: created badge component Adds Badge Component [V1] Jul 5, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 6, 2022

Deploy Preview for enchanting-stroopwafel-5222c6 failed.

Name Link
🔨 Latest commit ba02663
🔍 Latest deploy log https://app.netlify.com/sites/enchanting-stroopwafel-5222c6/deploys/62cdbe04ea3c7b0009d2d5d9

@Raalzz Raalzz changed the title Adds Badge Component [V1] HOV-3 - Adds Badge Component [V1] Jul 6, 2022
@Raalzz Raalzz marked this pull request as ready for review July 11, 2022 12:07
@pruthvi2103 pruthvi2103 self-requested a review July 12, 2022 07:49
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one change, it looks good!

Comment thread lib/src/components/Badge/Badge.tsx Outdated
Comment thread lib/src/components/Badge/Badge.tsx
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pruthvi2103 pruthvi2103 merged commit 997e694 into main Jul 13, 2022
@pruthvi2103 pruthvi2103 mentioned this pull request Jul 28, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Component Addition of new Components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants