Skip to content

Feat: loading support added for Select Component#142

Merged
pruthvi2103 merged 2 commits intomainfrom
select-loading
Nov 22, 2022
Merged

Feat: loading support added for Select Component#142
pruthvi2103 merged 2 commits intomainfrom
select-loading

Conversation

@saurabhsutar192
Copy link
Copy Markdown
Contributor

@saurabhsutar192 saurabhsutar192 commented Nov 22, 2022

Loading Support added.

Description

Loading Support added.

Motivation and Context

No loader :(

How Has This Been Tested?

Manual Test and local build successful

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@saurabhsutar192 saurabhsutar192 added the enhancement New feature or request label Nov 22, 2022
@saurabhsutar192 saurabhsutar192 self-assigned this Nov 22, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 22, 2022 •
edited
Loading

✅ Deploy Preview for hover-design canceled.

Name Link
🔨 Latest commit 4071a22
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/637c9299681bea0008bff16b

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pruthvi2103 pruthvi2103 changed the title Feat: loading support added Feat: loading support added for Select Component Nov 22, 2022
pruthvi2103
pruthvi2103 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pruthvi2103 pruthvi2103 merged commit 9c54b11 into main Nov 22, 2022
@pruthvi2103 pruthvi2103 deleted the select-loading branch November 22, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pruthvi2103 pruthvi2103 pruthvi2103 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@saurabhsutar192 saurabhsutar192

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saurabhsutar192 @pruthvi2103