HOV-50 | Added New component Breadcrumb #133
Merged
pruthvi2103 merged 16 commits intoantstackio:mainfrom Oct 13, 2022
AnilHash:main
Merged
HOV-50 | Added New component Breadcrumb #133pruthvi2103 merged 16 commits intoantstackio:mainfrom AnilHash:main
pruthvi2103 merged 16 commits intoantstackio:mainfrom
AnilHash:main
Conversation
Anil breadcrumb
Updated code
Updated doc
✅ Deploy Preview for hover-design ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Added Example
|
Kudos, SonarCloud Quality Gate passed!
|
pruthvi2103
suggested changes
Oct 13, 2022
Comment on lines
+8
to
+17
| type crumb = { | ||
| title: string; | ||
| href?: string; | ||
| }; | ||
|
|
||
| export interface BreadcrumbProps { | ||
| crumbs: Array<crumb>; | ||
| separator?: string | React.ReactNode; | ||
| className?: string; | ||
| } |
Contributor
There was a problem hiding this comment.
please move this into a seperate file called breadcrumb.types.ts
pruthvi2103
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial commit for Breadcrumb Component.
Description
Breadcrumb component.
Motivation and Context
Adds new component to arsenal of hover.
How Has This Been Tested?
Has been tested manually.
Screenshots (if appropriate):
Types of changes
[x] New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.