Skip to content

Select Value Changes #131

Merged
Raalzz merged 3 commits intomainfrom
select-changes
Oct 13, 2022
Merged

Select Value Changes #131
Raalzz merged 3 commits intomainfrom
select-changes

Conversation

@saurabhsutar192
Copy link
Copy Markdown
Contributor

@saurabhsutar192 saurabhsutar192 commented Oct 12, 2022 •
edited
Loading

Changed value format of select and also enabled onChange Function to trigger regardless of controlled or uncontrolled

Motivation and Context

The current value format has an insufficient amt of data

How Has This Been Tested?

local Build successful and manual testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@saurabhsutar192 saurabhsutar192 added enhancement New feature or request High priority High Priority labels Oct 12, 2022
@saurabhsutar192 saurabhsutar192 added this to the v0.1.10-alpha milestone Oct 12, 2022
@saurabhsutar192 saurabhsutar192 self-assigned this Oct 12, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 12, 2022 •
edited
Loading

✅ Deploy Preview for hover-design canceled.

Name Link
🔨 Latest commit 8d59e30
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/6346aad0b81000000c6742ef

@saurabhsutar192 saurabhsutar192 added the DO NOT MERGE Experiments or WIP, do not merge label Oct 12, 2022
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Raalzz
Raalzz approved these changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Raalzz Raalzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raalzz Raalzz merged commit 2c3c882 into main Oct 13, 2022
@Raalzz Raalzz deleted the select-changes branch October 13, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Raalzz Raalzz Raalzz approved these changes

Assignees

@saurabhsutar192 saurabhsutar192

Labels

DO NOT MERGE Experiments or WIP, do not merge enhancement New feature or request High priority High Priority

Projects

None yet

Milestone

v0.1.10-alpha

Development

Successfully merging this pull request may close these issues.

2 participants

@saurabhsutar192 @Raalzz