Merged
Conversation
✅ Deploy Preview for hover-design canceled.
|
3 tasks
pruthvi2103
suggested changes
Sep 28, 2022
Contributor
pruthvi2103
left a comment
pruthvi2103
left a comment
There was a problem hiding this comment.
some minor questions
| | size | `number` | 30 | Yes | | ||
| | thickness | `number` | `size / 5` | Yes | | ||
| | color | `string` | `#408FEC` | Yes | | ||
| | dashLength | `number` | `1/4 Circumference` | Yes | |
Contributor
There was a problem hiding this comment.
circumference is not controlled by consumer, any way to control this?
Contributor
Author
There was a problem hiding this comment.
circumference will depend on size
| margin, | ||
| isBlock, | ||
| children, | ||
| ...nativeProps |
Contributor
Author
There was a problem hiding this comment.
slacked you the details
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Loader Component
Description
Adds a Spinning Loader
Motivation and Context
Loader Needed
How Has This Been Tested?
Local Build Successful and manually tested
Screenshots (if appropriate):
Types of changes
Checklist: