Skip to content

HOV-29 | Adds Alert component #124

Merged
pruthvi2103 merged 9 commits intomainfrom
alert-component
Sep 30, 2022
Merged

HOV-29 | Adds Alert component #124
pruthvi2103 merged 9 commits intomainfrom
alert-component

Conversation

@saurabhsutar192
Copy link
Copy Markdown
Contributor

Adds Alert Component

Description

A customizable Alert component with type, variant support etc

Motivation and Context

Alert Component Needed!

How Has This Been Tested?

Local Build Success and manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@saurabhsutar192 saurabhsutar192 added the New Component Addition of new Components label Sep 21, 2022
@saurabhsutar192 saurabhsutar192 added this to the v0.1.10-alpha milestone Sep 21, 2022
@saurabhsutar192 saurabhsutar192 self-assigned this Sep 21, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 21, 2022

Deploy Preview for hover-design ready!

Name Link
🔨 Latest commit dc31d59
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/6336918b8818bb0008592996
😎 Deploy Preview https://deploy-preview-124--hover-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@saurabhsutar192 saurabhsutar192 added the DO NOT MERGE Experiments or WIP, do not merge label Sep 21, 2022
@saurabhsutar192 saurabhsutar192 removed the DO NOT MERGE Experiments or WIP, do not merge label Sep 21, 2022
@saurabhsutar192 saurabhsutar192 linked an issue Sep 21, 2022 that may be closed by this pull request
3 tasks
@saurabhsutar192 saurabhsutar192 changed the title HOV-31 | Adds Alert component HOV-29 | Adds Alert component Sep 22, 2022
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small question

Comment thread lib/src/components/Button/Button.stories.tsx Outdated
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pruthvi2103
Copy link
Copy Markdown
Contributor

@saurabhsutar192 can you please resolve the code smells pointed out by sonar cloud

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pruthvi2103 pruthvi2103 merged commit 6fc209d into main Sep 30, 2022
@pruthvi2103 pruthvi2103 deleted the alert-component branch September 30, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Component Addition of new Components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HOV-29 | Alert Component

2 participants