Skip to content

Tooltip Component and Popover Changes#114

Merged
Raalzz merged 2 commits intomainfrom
tooltip-component
Sep 16, 2022
Merged

Tooltip Component and Popover Changes#114
Raalzz merged 2 commits intomainfrom
tooltip-component

Conversation

@saurabhsutar192
Copy link
Copy Markdown
Contributor

@saurabhsutar192 saurabhsutar192 commented Sep 16, 2022

Tooltip Component and Popover changes

Description

Created Tooltip Component and made some changes in the popover component

Motivation and Context

Tooltip is a lightweight popover that supports only labels unlike popover which supports the whole JSX element

How Has This Been Tested?

Local Build is successful and manually tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@saurabhsutar192 saurabhsutar192 added enhancement New feature or request New Component Addition of new Components labels Sep 16, 2022
@saurabhsutar192 saurabhsutar192 added this to the v0.1.9-alpha milestone Sep 16, 2022
@saurabhsutar192 saurabhsutar192 self-assigned this Sep 16, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 16, 2022

Deploy Preview for hover-design canceled.

Name Link
🔨 Latest commit 7aa72ed
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/632445cf44cb620009b5dc35

Copy link
Copy Markdown
Member

@Raalzz Raalzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

Comment thread lib/src/components/Tooltip/tooltip.css.ts
Comment thread lib/src/components/Tooltip/tooltip.types.ts Outdated
Copy link
Copy Markdown
Member

@Raalzz Raalzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raalzz Raalzz merged commit 078cabb into main Sep 16, 2022
@Raalzz Raalzz deleted the tooltip-component branch September 16, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request New Component Addition of new Components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants