Skip to content

HOV-31 | Adds Stepper component#112

Merged
pruthvi2103 merged 11 commits intoantstackio:mainfrom
Raalzz:HOV-31/Stepper
Oct 13, 2022
Merged

HOV-31 | Adds Stepper component#112
pruthvi2103 merged 11 commits intoantstackio:mainfrom
Raalzz:HOV-31/Stepper

Conversation

@Raalzz
Copy link
Copy Markdown
Member

@Raalzz Raalzz commented Sep 16, 2022

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 16, 2022 •
edited
Loading

✅ Deploy Preview for hover-design ready!

Name Link
🔨 Latest commit 324d48b
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/6347e83e705a2d0008f2c735
😎 Deploy Preview https://deploy-preview-112--hover-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Raalzz Raalzz requested a review from pruthvi2103 October 12, 2022 20:20
@Raalzz Raalzz marked this pull request as ready for review October 12, 2022 20:29
@Raalzz Raalzz self-assigned this Oct 13, 2022
@Raalzz Raalzz added this to the v0.1.10-alpha milestone Oct 13, 2022
pruthvi2103
pruthvi2103 suggested changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor variable related changes

Comment thread lib/src/components/Stepper/Stepper.tsx Outdated
Comment thread lib/src/components/Stepper/stepper.types.ts
@saurabhsutar192
Copy link
Copy Markdown
Contributor

saurabhsutar192 commented Oct 13, 2022

DIvider LGTM

@pruthvi2103
Copy link
Copy Markdown
Contributor

pruthvi2103 commented Oct 13, 2022

@Raalzz also i see one code-smell being introduced

@Raalzz
Copy link
Copy Markdown
Member Author

Raalzz commented Oct 13, 2022

@Raalzz also i see one code-smell being introduced

Yaa checked it

@Raalzz also i see one code-smell being introduced

Its asking me to remove .reduce 🥲

@pruthvi2103
Copy link
Copy Markdown
Contributor

pruthvi2103 commented Oct 13, 2022

sad, we will look at codesmell later then

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

pruthvi2103
pruthvi2103 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pruthvi2103 pruthvi2103 merged commit 3ff9236 into antstackio:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pruthvi2103 pruthvi2103 pruthvi2103 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Raalzz Raalzz

Labels

None yet

Projects

None yet

Milestone

v0.1.10-alpha

Development

Successfully merging this pull request may close these issues.

4 participants

@Raalzz @saurabhsutar192 @pruthvi2103 @onlyveen