Skip to content

HOV-11 | Popover component#108

Merged
pruthvi2103 merged 4 commits intomainfrom
popover-component
Sep 16, 2022
Merged

HOV-11 | Popover component#108
pruthvi2103 merged 4 commits intomainfrom
popover-component

Conversation

@saurabhsutar192
Copy link
Copy Markdown
Contributor

Popover Component

Description

A small popover component that sits around your desired component.

Motivation and Context

To provide additional information about anything which is very handy and doesn't take any space

How Has This Been Tested?

Local Build Successful and manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 15, 2022

Deploy Preview for hover-design ready!

Name Link
🔨 Latest commit 012e6f6
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/63241b3bcafcc50008ac55fb
😎 Deploy Preview https://deploy-preview-108--hover-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@saurabhsutar192 saurabhsutar192 self-assigned this Sep 15, 2022
@saurabhsutar192 saurabhsutar192 added this to the v0.1.9-alpha milestone Sep 15, 2022
@saurabhsutar192 saurabhsutar192 added the New Component Addition of new Components label Sep 15, 2022
@Raalzz Raalzz linked an issue Sep 16, 2022 that may be closed by this pull request
3 tasks
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments..

Comment thread lib/src/components/Popover/Popover.tsx
Comment thread lib/src/components/Popover/Popover.tsx Outdated
@pruthvi2103 pruthvi2103 changed the title Popover component HOV-11 | Popover component Sep 16, 2022
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make a useLockFocus hook issue @saurabhsutar192

@pruthvi2103 pruthvi2103 merged commit 63fe62a into main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Component Addition of new Components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Popover Component

3 participants