Skip to content

HOV-14 | Checkbox Component#100

Merged
pruthvi2103 merged 7 commits intoantstackio:mainfrom
Raalzz:chores/checkbox
Sep 16, 2022
Merged

HOV-14 | Checkbox Component#100
pruthvi2103 merged 7 commits intoantstackio:mainfrom
Raalzz:chores/checkbox

Conversation

@Raalzz
Copy link
Copy Markdown
Member

@Raalzz Raalzz commented Sep 13, 2022 •
edited
Loading

Description

Adds Checkbox Component

Motivation and Context

Closes #39

How Has This Been Tested?

Tested in local and Docs

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 13, 2022 •
edited
Loading

✅ Deploy Preview for hover-design canceled.

Name Link
🔨 Latest commit 10965ea
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/63242728e710e5000c4f9984

@Raalzz Raalzz added this to the v0.1.9-alpha milestone Sep 13, 2022
@Raalzz Raalzz marked this pull request as ready for review September 14, 2022 08:17
@pruthvi2103
Copy link
Copy Markdown
Contributor

pruthvi2103 commented Sep 15, 2022

is this ready for review @Raalzz ?

@Raalzz
Copy link
Copy Markdown
Member Author

Raalzz commented Sep 15, 2022

Yes

@Raalzz Raalzz requested a review from pruthvi2103 September 16, 2022 05:14
pruthvi2103
pruthvi2103 suggested changes Sep 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

Comment thread lib/src/components/_internal/Icons/SvgCheck.tsx Outdated
Comment thread lib/src/components/_internal/Icons/SvgDash.tsx Outdated
@pruthvi2103 pruthvi2103 self-requested a review September 16, 2022 07:37
pruthvi2103
pruthvi2103 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pruthvi2103 pruthvi2103 merged commit 4596588 into antstackio:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pruthvi2103 pruthvi2103 pruthvi2103 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Raalzz Raalzz

Labels

None yet

Projects

None yet

Milestone

v0.1.9-alpha

Development

Successfully merging this pull request may close these issues.

HOV-14 | Checkbox Component

2 participants

@Raalzz @pruthvi2103