Open
Conversation
This comment has been minimized.
This comment has been minimized.
|
I think you could just add it along with the rest of the terraform code, so you can reuse the same LB rather than having a separate project |
bethcryer
suggested changes
Mar 17, 2023
This comment has been minimized.
This comment has been minimized.
… in order to be visible
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Bump Microsoft.AspNetCore.Mvc.Testing from 7.0.3 to 7.0.4 Bumps [Microsoft.AspNetCore.Mvc.Testing](https://github.com/dotnet/aspnetcore) from 7.0.3 to 7.0.4. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.3...v7.0.4) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Mvc.Testing dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): update packages.lock.json --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump Alba from 7.3.0 to 7.4.0 Bumps [Alba](https://github.com/JasperFx/alba) from 7.3.0 to 7.4.0. - [Release notes](https://github.com/JasperFx/alba/releases) - [Commits](JasperFx/alba@v7.3.0...v7.4.0) --- updated-dependencies: - dependency-name: Alba dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): update packages.lock.json --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump AWSSDK.CloudWatchLogs from 3.7.104.33 to 3.7.104.40 Bumps [AWSSDK.CloudWatchLogs](https://github.com/aws/aws-sdk-net) from 3.7.104.33 to 3.7.104.40. - [Release notes](https://github.com/aws/aws-sdk-net/releases) - [Commits](https://github.com/aws/aws-sdk-net/commits) --- updated-dependencies: - dependency-name: AWSSDK.CloudWatchLogs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps): update packages.lock.json --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
bethcryer
suggested changes
Mar 24, 2023
This comment has been minimized.
This comment has been minimized.
bethcryer
suggested changes
Mar 27, 2023
This comment has been minimized.
This comment has been minimized.
bethcryer
suggested changes
Apr 4, 2023
Contributor
bethcryer
left a comment
bethcryer
left a comment
There was a problem hiding this comment.
Checkov has flagged some issues in the pipeline that need addressing. If the rule they're complaining about isn't valid, you can add an exception in the terraform code.
bethcryer
reviewed
Apr 5, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… be implemented in a future security update
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Tests run with 277 passed and 0 failed in 22845ms. |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added config for deploying Splunk in an EC2 instance.
The terraform code is within it's own folder to avoid destroying other defined infrastructures.