Skip to content

fix: handle special characters in paths and git snapshot reading logic(#9804)#9807

Merged
adamdotdevin merged 1 commit intoanomalyco:devfrom
shirukai:dev
Jan 21, 2026
Merged

fix: handle special characters in paths and git snapshot reading logic(#9804)#9807
adamdotdevin merged 1 commit intoanomalyco:devfrom
shirukai:dev

Conversation

@shirukai
Copy link
Contributor

fix: #9804

@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@adamdotdevin adamdotdevin merged commit cf6ad4c into anomalyco:dev Jan 21, 2026
2 checks passed
adamdotdevin added a commit that referenced this pull request Jan 22, 2026
@reneleonhardt
Copy link

Instead of just reverting, wouldn't it be better to add unit tests which this PR didn't contain, so a better fix could be implemented in the future?

@shirukai
Copy link
Contributor Author

shirukai commented Feb 6, 2026

Instead of just reverting, wouldn't it be better to add unit tests which this PR didn't contain, so a better fix could be implemented in the future?

Hey @adamdotdevin @reneleonhardt,
Quick question: was the revert mainly due to the missing unit tests for this fix, or were there other bugs/regressions that came up with the implementation?
Just want to make sure I address the core issue fully before submitting a revised PR, and happy to add tests/fix any other problems needed.

Instead of just reverting, wouldn't it be better to add unit tests which this PR didn't contain, so a better fix could be implemented in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File paths with special characters (#) or non-ASCII characters fail to load in Diff/Review view

3 participants