fix: render permission and question prompts from nested subagent session#13719
Open
ro-hansolo wants to merge 2 commits intoanomalyco:devfrom
Open
fix: render permission and question prompts from nested subagent session#13719ro-hansolo wants to merge 2 commits intoanomalyco:devfrom
ro-hansolo wants to merge 2 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: I found a potentially related PR: PR #10539: This PR may be related because it also addresses an issue with nested subagents (sub-sub agents) not being able to ask questions. Your PR #13719 fixes a similar problem where permission and question prompts from nested subagent sessions were silently hanging. Both involve rendering prompts from deeper levels in the session hierarchy. However, this appears to be a historical PR that may have already been merged. The current PR (#13719) likely addresses a regression or a similar issue with a different implementation approach. |
ro-hansolo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #13715
Permission and question prompts from nested subagent sessions (grandchild+) silently hang. The
children()memo insession/index.tsxonly collects direct child sessions, so events from deeper sessions are never rendered in the TUI.Added a
descendants()memo that walks the full session tree using Set iteration. Permissions and questions now usedescendants()while tab navigation still uses the originalchildren().How did you verify your code works?
Spawned a general subagent that spawns another general subagent requiring bash permission. Before: TUI hangs silently. After: permission prompt surfaces. Video attached.
Before:
Screen.Recording.2026-02-15.at.3.58.30.PM.mov
After:
Bug.Fix.mov