fix(run): disable question tool in non-interactive mode#11895
Open
justindra wants to merge 1 commit intoanomalyco:devfrom
Open
fix(run): disable question tool in non-interactive mode#11895justindra wants to merge 1 commit intoanomalyco:devfrom
justindra wants to merge 1 commit intoanomalyco:devfrom
Conversation
The question tool was still available to the model during `opencode run` even though session permissions denied it. This caused the run to hang indefinitely waiting for a response that would never come. Fixed by passing session permissions to LLM.resolveTools so tools with deny rules are properly filtered out before being sent to the model.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11899
Summary
opencode runhanging when the model attempts to use the question toolProblem
When running
opencode run, if the model tried to use the question tool, it would hang indefinitely because:run.tscorrectly sets session permission rules to deny thequestionpermissionLLM.resolveToolsonly checkedagent.permissionwhen filtering disabled toolsQuestion.ask()waits forever for a response that never comesSolution
Updated
LLM.resolveToolsto merge both agent and session permissions when determining which tools should be disabled.Changes
packages/opencode/src/session/llm.ts: AddedsessionPermissiontoStreamInputtype and updatedresolveToolsto merge it with agent permissionspackages/opencode/src/session/prompt.ts: Passsession.permissionwhen callingprocessor.process()Verification
Tested locally with
bun run dev run "ask me a question using the question tool"- the model no longer attempts to use the question tool.