This repository was archived by the owner on Mar 31, 2025. It is now read-only.
feat(typescript): resolve typescript module paths from compilerOptions#258
Open
dherges wants to merge 1 commit intoangular:masterfrom
Open
feat(typescript): resolve typescript module paths from compilerOptions#258dherges wants to merge 1 commit intoangular:masterfrom
dherges wants to merge 1 commit intoangular:masterfrom
Conversation
dherges
commented
Jan 23, 2018
| path: string; | ||
| outputPath: string; | ||
| content: string; | ||
| importFrom?: string; |
Contributor
Author
There was a problem hiding this comment.
Is adding this property a good way to solve my use case?
| basePath = path.resolve(__dirname, '../../mocks'); | ||
| }); | ||
|
|
||
| it('should return the resolved module path derived by compilerOptions.paths', () => { |
Contributor
Author
There was a problem hiding this comment.
Should I add another test w/o options.paths?
Contributor
|
Do the |
Contributor
|
I am worried that this reverse lookup for every call is needlessly expensive. If it is the case that the paths values are always specific files, then we could invert this hash just once and then get fast lookups as needed; perhaps storing it alongside the other information that comes from TsParser? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How It's Used
Configure TypeScript
compilerOptions.pathsto resolve (and eventually display) a module path for a npm package.Similar to Material: https://github.com/angular/material2/blob/master/tools/dgeni/index.ts#L112