Popover / Tooltip positioning with appendToBody set to true

[bowenisdum]

Not sure if this is a real bug or not, but on the project I am working on, the tooltip/popover position is wrong when appendToBody is set to true, the position = $position.position( element ); returns the offset relative to the parent of the tooltip triggering element, not the body, it seems to be fixed by setting position = $position.offset( element ); when the appendToBody option is true

[pkozlowski-opensource]

@bowenisdum I think I know what you are talking about and I think it is a good catch! Would you mind preparing a small plunk with a reproduce scenario (we need to make sure that we are fixing the right thing!)? Or better yet, send a pull request - it should be fairly easy, you will get famous and the whole community will be grateful :-)

[bowenisdum]

let me try to do that

[joshdmiller]

Doh! Since we can't set provider options in the official demo, I'm thinking we should add a local *-append-to-body attribute just so we can include one in the demo to avoid regressions.

[pkozlowski-opensource]

+1 @joshdmiller

Now that we've got positioning right (or at least I hope so!) the "append to body" option is really useful only for cases where people are using pseud-elements CSS selectors. Which means that it really depends on an element (its placement) and probably shouldn't be set globally in a provider.

[bowenisdum]

http://plnkr.co/edit/UhmeEPucwQrbuJzASBNj?p=preview here is a plunk that replicates the problem i will try to send the pull request now..

[joshdmiller]

@pkozlowski-opensource When #369 gets merged, I want to make some simple changes to the provider's API and add documentation for it, so that would be a good time to add the new attribute as well.

[pkozlowski-opensource]

Works OK after the fix: http://plnkr.co/edit/QXac7aS0tDIvzoALil8Z?p=preview