Websocketmain/sss 35 by SameerShaikhAcc · Pull Request #15 · angel-one/smartapi-java

SameerShaikhAcc · 2023-07-19T06:34:55Z

Integrated market data api.
added junit test cases for market data API.
updated readme.md file.

anurag-amx

anurag-amx · 2023-07-20T05:18:48Z

+			String url = routes.get("api.market.data");
+			JSONObject response = smartAPIRequestHandler.postRequest(this.apiKey, url, params, accessToken);
+			return response.getJSONObject("data");
+		}catch (Exception | SmartAPIException e) {


what is need of calling SmartAPIException while you are already calling Exception?

The SmartAPIException class catches custom messages and custom error codes.
also, it extends to the Throwable class. So need to catch it separately

anurag-amx · 2023-07-20T05:19:04Z

+			JSONObject response = smartAPIRequestHandler.postRequest(this.apiKey, url, params, accessToken);
+			return response.getJSONObject("data");
+		}catch (Exception | SmartAPIException e) {
+			System.out.println(e.getMessage());


Why are you using System.out.println(e.getMessage());?

I Have taken references from other methods, In the catch block the error message is printed.
I can use logger instead of System.out.println and handle null but the code will differ from other methods.

some referred methods

public String candleData(JSONObject params) { try { String url = routes.get("api.candle.data"); JSONObject response = smartAPIRequestHandler.postRequest(this.apiKey, url, params, accessToken); System.out.println(response); return response.getString("data"); } catch (Exception | SmartAPIException e) { System.out.println(e.getMessage()); return null; } } public JSONObject gttRuleDetails(Integer id) { try { JSONObject params = new JSONObject(); params.put("id", id); String url = routes.get("api.gtt.details"); JSONObject response = smartAPIRequestHandler.postRequest(this.apiKey, url, params, accessToken); System.out.println(response); return response.getJSONObject("data"); } catch (Exception | SmartAPIException e) { System.out.println(e.getMessage()); return null; } }

That is fine . Please start correcting code as suggested. We can start from marketdata.

anurag-amx · 2023-07-20T05:30:44Z

+    public void getMarketData(SmartConnect smartConnect) {
+
+        JSONObject payload = new JSONObject();
+        payload.put("mode", "FULL");


There is 3 modes. LTP("LTP"),
OHLC("OHLC"),
FULL("FULL");

why did you cover FULL only? What about the rest?

Apologies for the confusion. I demonstrated the "FULL" mode in the code snippet for simplicity. However, users can easily modify the code to request data in "LTP" or "OHLC" modes by changing the value within the payload JSON object. For "LTP" mode, they should replace the value with "LTP," and for "OHLC" mode, they should use "OHLC" instead.
For EG:
payload.put("mode", "FULL");
payload.put("mode", "LTP");
payload.put("mode", "OHLC");

You should mention this in comment section

anurag-amx · 2023-07-20T05:31:41Z

+    /** Market Data */
+    public void getMarketData(SmartConnect smartConnect) {
+        // Create the payload object
+        JSONObject payload = new JSONObject();


Cover all 3 modes in 3 different funtion.

where is rest of function?

anurag-amx · 2023-07-20T05:50:06Z

+             response.getJSONObject("data");
+        }catch (Exception | SmartAPIException e) {
+            e.printStackTrace();
+            System.out.println(e.getMessage());


why you need SmartAPIException e while you capturing Exception?

it extends to the Throwable class. So need to catch it separately.

Please read java document again and comment carefully. If java doc is not understood, we can connect.

anurag-amx · 2023-07-20T05:50:20Z

+             response.getJSONObject("data");
+        }catch (Exception | SmartAPIException e) {
+            e.printStackTrace();
+            System.out.println(e.getMessage());


System.out.println(e.getMessage());?

I Have taken references from other methods, In the catch block the error message is printed.
I can use logger instead of System.out.println and handle null but the code will differ from other methods.

anurag-amx · 2023-07-20T05:51:22Z

+        return payload;
+    }
+
+    private static JSONObject createMarketDataResponse() {  JSONObject jsonObject = new JSONObject();


Cover test cases for all 3 modes.

anurag-amx · 2023-07-20T05:52:20Z

+
+
+
+    @Test


Write Method level comment on each method.

anurag-amx · 2023-08-03T04:01:39Z

+    public void getMarketData(SmartConnect smartConnect) {
+
+        JSONObject payload = new JSONObject();
+        payload.put("mode", "FULL");


You should mention this in comment section

anurag-amx · 2023-08-03T04:03:19Z

+			JSONObject response = smartAPIRequestHandler.postRequest(this.apiKey, url, params, accessToken);
+			return response.getJSONObject("data");
+		}catch (Exception | SmartAPIException e) {
+			System.out.println(e.getMessage());


That is fine . Please start correcting code as suggested. We can start from marketdata.

anurag-amx · 2023-08-03T04:04:03Z

+    /** Market Data */
+    public void getMarketData(SmartConnect smartConnect) {
+        // Create the payload object
+        JSONObject payload = new JSONObject();


where is rest of function?

anurag-amx · 2023-08-03T04:05:24Z

+             response.getJSONObject("data");
+        }catch (Exception | SmartAPIException e) {
+            e.printStackTrace();
+            System.out.println(e.getMessage());


Please read java document again and comment carefully. If java doc is not understood, we can connect.

SameerShaikhAcc added 5 commits July 19, 2023 11:27

added test for market data api

6ea3eaf

updated readme.md

91d51d7

added java doc for market data api

21ee4d0

changes in example

c3ca208

changes in example

a8f96f8

anurag-amx requested changes Jul 20, 2023

View reviewed changes

SameerShaikhAcc added 2 commits September 20, 2023 09:20

git comments

c2023a5

git comments

db4428d

anurag-amx approved these changes Sep 22, 2023

View reviewed changes

anurag-amx merged commit f2f8556 into angel-one:main Sep 22, 2023

Conversation

SameerShaikhAcc commented Jul 19, 2023

Uh oh!

anurag-amx left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SameerShaikhAcc Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

SameerShaikhAcc Jul 20, 2023 •

edited

Loading