Open
Conversation
andycb
requested changes
May 5, 2017
Owner
There was a problem hiding this comment.
Converting the whole project seems like a good idea.
There 's a few things checked in that don't need to be, though:
- the .suo files
- VSWorkspaceState.json
- the .sqlite files
- the contents of the obj folder
- the bin folder
Can you also update the docs please, because they still talk a lot about mono.
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of creating two new projects for .net core, I converted the two existing projects to .Net Core (PiSharp.LibGpio and PiSharpGpio). Those are now able to be run in windows/linux/osx without an emulator (mono). I did not convert the PiSharp.GpioSimulator to .Net core as of yet as WinForms is not supported in core, so that will still need mono. This may have to be converted to maybe a web application or find a 3rd party library that has some type of GUI similar to WinForms or WPF.