feat: Add seekForward and seekBackward#49
Open
dyong1 wants to merge 6 commits intoandrehaveman:masterfrom
Open
feat: Add seekForward and seekBackward#49dyong1 wants to merge 6 commits intoandrehaveman:masterfrom
dyong1 wants to merge 6 commits intoandrehaveman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thank you for running this awesome project. I'm opening this PR to add seeking capability for extending vscode-spotify.
You can find the main changes in 14d3e45. The others are just formatting and fixing the original tests. I hope you like this PR and let it merged soon.
Regarding the quality of this PR, you can check the tests written in the commit above. Also, I've run the test suite +10 times on my local as followed by: