GenerateButtonSignatureTest.testButtonSignatureWithJSONObject is a flaky buttom#17
Open
TheGreatRandall wants to merge 1 commit intoamzn:masterfrom
Open
GenerateButtonSignatureTest.testButtonSignatureWithJSONObject is a flaky buttom#17TheGreatRandall wants to merge 1 commit intoamzn:masterfrom
TheGreatRandall wants to merge 1 commit intoamzn:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The testButtonSignatureWithJSONObject() test can not pass the nondex(https://github.com/TestingResearchIllinois/NonDex) check. The problem is the data inside the JSON variable is non-deterministic and can't guarentee the consistance of output string.
Description of changes:
I assertequal the JSONObject instead of String. I use the String is given in testButtonSignatureWithString function to build a JSON object. And using JSONObject.similar(JSONObject) to check the payload
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.