Update gemm tiling dim (n) and move function to appropriate spot#41
Closed
kurtis-b-1 wants to merge 2 commits intoamd:develfrom
Closed
Update gemm tiling dim (n) and move function to appropriate spot#41kurtis-b-1 wants to merge 2 commits intoamd:develfrom
kurtis-b-1 wants to merge 2 commits intoamd:develfrom
Conversation
Contributor
Author
|
@andrej Not sure if this is needed since you're removing the CMake build system, but created this PR just to point to a small issue in the tests for GEMM. |
Collaborator
|
The default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason tiling dim
nfor GEMM in CMake was32instead of64--updated it to be64.Changed
nincreased to64add_gemm_archivefunction was in an incorrect spot, so moved it with the other functionsPR Merge Checklist
develcommit and pointing todevel.