Skip to content

Update gemm tiling dim (n) and move function to appropriate spot#41

Closed
kurtis-b-1 wants to merge 2 commits intoamd:develfrom
kurtis-b-1:update-gemm-tiling
Closed

Update gemm tiling dim (n) and move function to appropriate spot#41
kurtis-b-1 wants to merge 2 commits intoamd:develfrom
kurtis-b-1:update-gemm-tiling

Conversation

@kurtis-b-1
Copy link
Contributor

@kurtis-b-1 kurtis-b-1 commented Dec 1, 2025

For some reason tiling dim n for GEMM in CMake was 32 instead of 64--updated it to be 64.

Changed

  • Gemm tiling dimension n increased to 64
  • The add_gemm_archive function was in an incorrect spot, so moved it with the other functions

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR has been reviewed and approved.
  3. All checks are passing.

@kurtis-b-1 kurtis-b-1 requested a review from andrej December 1, 2025 21:32
@kurtis-b-1
Copy link
Contributor Author

@andrej Not sure if this is needed since you're removing the CMake build system, but created this PR just to point to a small issue in the tests for GEMM.

@andrej
Copy link
Collaborator

andrej commented Dec 2, 2025

The default n dimension is already changed to 64 in #37 :)

@andrej andrej closed this Dec 2, 2025
@kurtis-b-1 kurtis-b-1 deleted the update-gemm-tiling branch December 2, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants