Merged
Conversation
Owner
Ok, full confession: I may be bad at scoping what a good first issue is or not. It's also hard to know what's involved before you've implemented the thing. I appreciate this feedback. |
alxmrs
reviewed
Mar 23, 2026
Owner
alxmrs
left a comment
There was a problem hiding this comment.
Thanks for this PR! Here is my initial round of feedback. Mostly questions, some suggestions.
Collaborator
Author
|
Thanks for the review; a bit busy this early week, but will definitely get to this later. I'm also planning to first make a docs infra PR first so this can build on that docs. |
932c8b3 to
8789b1e
Compare
…isel works correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144
After attempting this, I realized it did not feel like a good first issue~ Note I used Claude Opus to plan and write this.
Two tiers based on calendar type:
Now this runs:
However as you can see, there are a lot of NaNs; to be fixed in a separate PR in #151