Removed superfluous python-xlib dependency#199
Merged
acrisci merged 3 commits intoaltdesktop:masterfrom Sep 11, 2022
Merged
Conversation
Member
|
Ok it's probably better this way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #198.
This was a feature released in 1.3.0 (see changelog), but then regressed by a merge request in 2.0.1, #116
Someone must have realized that this replacement method was a bad idea, because the current branch is back to using the
i3/sway --get-socketpathmethod. This revert was however incomplete, as the method added to #116 still remains, along with thepython-xlibdependency.Anyhow, the pull request purges any use of
python-xlib. It's still used in testing, but there the package is separately installed when creating the docker testing image.TL;DR: Don't accept pull request by script kiddies that address non-existent issues, regress features, and add package dependencies; all in the name of "removing a subprocess call" by replacing it with 5 method calls to
python-xlib.