fix: improve/extend LuaLS annotations, code greatly optimized#2
Merged
aikhe merged 1 commit intoaikhe:masterfrom Feb 15, 2026
Merged
fix: improve/extend LuaLS annotations, code greatly optimized#2aikhe merged 1 commit intoaikhe:masterfrom
aikhe merged 1 commit intoaikhe:masterfrom
Conversation
Signed-off-by: Guennadi Maximov C <g.maxc.fox@protonmail.com>
DrKJeff16
commented
Feb 15, 2026
Contributor
Author
DrKJeff16
left a comment
DrKJeff16
left a comment
There was a problem hiding this comment.
For clarification I converted this into a function because of the danger of users being able to change the defaults indirectly.
Setting this as a return value guarantees that the default values won't run the risk of accidental changes.
Owner
|
yo, big fan! agreed, having no docs about
good to know, appreciate the help! |
Contributor
Author
|
@aikhe I'm working on an annotated Pull Request for |
Owner
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello there, developer of
triforce.nvimhere. I took a look at your project and it's quite lovely!I wanted to improve development by extending all possible LuaLS type annotations.
I also made some minimal code optimizations.
Please, if there's any feedback let me know!
voltcan be a bit of a pain to work with IMO because of the variably-nested lists...Sorry for such a big PR btw!