Rename Coordinates class to Traveller
#535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingbuzzman
approved these changes
Aug 8, 2025
Contributor
kingbuzzman
left a comment
kingbuzzman
left a comment
There was a problem hiding this comment.
Other than my comments, which are opinions and you should wait for @adamchainz to weight in on this; looks pretty good!
adamchainz
reviewed
Aug 8, 2025
Contributor
Author
|
Thanks @kingbuzzman and @adamchainz for the suggestion! PTAL |
adamchainz
force-pushed
the
resolve-issue-522
branch
from
eb37778 to
47a3597
Compare
mattwang44
force-pushed
the
resolve-issue-522
branch
2 times, most recently
from
6bd1732 to
2979474
Compare
Contributor
Author
|
resolved conflicts with v2.18.0 |
Owner
|
It's okay, you don't need to keep updating for conflicts. I'm holding on this one until i'm ready to do a major version bump with several breaking changes. |
adamchainz
force-pushed
the
resolve-issue-522
branch
from
b037183 to
b9c6069
Compare
adamchainz
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #533.