Skip to content

Safe spawn and where.not#344

Open
kbrock wants to merge 1 commit intoactive-hash:masterfrom
kbrock:satan_spawn
Open

Safe spawn and where.not#344
kbrock wants to merge 1 commit intoactive-hash:masterfrom
kbrock:satan_spawn

Conversation

@kbrock
Copy link
Copy Markdown
Collaborator

@kbrock kbrock commented Mar 31, 2026

  • where.not chains no longer can get corrupted from simple searches.
  • find_by no longer mutates the relation.

Fixes #338

Thanks Claude for the assist

- where.not chains no longer can get corrupted from simple searches.
- find_by no longer mutates the relation.

Fixes active-hash#338

Thanks Claude for the assist
@kbrock
Copy link
Copy Markdown
Collaborator Author

kbrock commented Mar 31, 2026

@flavorjones Hey. Any help with a review would be great. (and any suggestions how we can open this up would be very helpful too.

@stefafafan As a non-maintainer, can you review this? I haven't tried a non-maintainer review workflow before. UPDATE: just read the fine print

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ActiveHash::Relation#spawn passes conditions by reference, causing original Relation to be mutated when calling find_by multiple times

1 participant