Skip to content

fix: oci chart rendering version#3961

Closed
buroa wants to merge 1 commit intoactions:masterfrom
buroa:master
Closed

fix: oci chart rendering version#3961
buroa wants to merge 1 commit intoactions:masterfrom
buroa:master

Conversation

@buroa
Copy link
Copy Markdown

@buroa buroa commented Mar 9, 2025

This fixes a simple issue where upon rendering the chart with OCI manifests adds a +sha to it. This results in a failure to install because it's not a valid kubernetes label with the + in it.

Other charts replace the + with a _ and that seems to be the standard fix.

actions-runner-controller    0.10.1+9f0f5cfb9a0e    False        False    Helm install failed for release actions-runner-system/actions-runner-controller with chart gha-runner-scale-set-controller@0.10.1+9f0f5cfb9a0e: 1 error occurred:
                                                                              * Deployment.apps "actions-runner-controller" is invalid: spec.template.labels: Invalid value: "0.10.1+9f0f5cfb9a0e": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

Signed-off-by: Steven Kreitzer <skre@skre.me>
@buroa
Copy link
Copy Markdown
Author

buroa commented Mar 9, 2025

Closing in favor of #3729

@buroa buroa closed this Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant