fix: broken grunt test on modern Nodejs#370
Open
Shashwat325 wants to merge 1 commit intoaces:masterfrom
Open
Conversation
…d on modern Node.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grunt testwas broken on modern Node.js with the following error:Fatal error: The "cb" argument must be of type function. Received undefined
The dependencies on which the grunt test depends were outdated which led to this error. I fixed that by installing the newer versions of the libraries:
Upgraded grunt-contrib-qunit to latest version which now uses headless Chrome instead of abandoned phantomjs
Added qunit@2.20.0 files to test/lib/
Updated test HTML files to reference new qunit files
Upgraded grunt-contrib-compress to fix compress task
Fixed test/brainbrowser symlink for headless Chrome
Before fix
After fix
