feat(markdown-docx): add conditional transformer - #397#453
Merged
algomaster99 merged 1 commit intoalgoo-ooxmlfrom Aug 18, 2021
Merged
feat(markdown-docx): add conditional transformer - #397#453algomaster99 merged 1 commit intoalgoo-ooxmlfrom
algomaster99 merged 1 commit intoalgoo-ooxmlfrom
Conversation
transformation logic: OOXML<->CiceroMark rules: OPTIONAL_RULE tests Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
Collaborator
Author
|
@algomaster99 |
Comment on lines
+406
to
+414
| /** | ||
| * for optional hasSome and whenSome stand for same as would be in the ciceromark. | ||
| * for conditional, the following relations with optional can be made | ||
| * optional | conditional | ||
| * hasSome | isTrue | ||
| * whenSome | whenTrue | ||
| * whenFalse | whenFalse | ||
| * The properties for conditional are not added therefore. | ||
| */ |
algomaster99
approved these changes
Aug 18, 2021
Contributor
algomaster99
left a comment
algomaster99
left a comment
There was a problem hiding this comment.
Looks good to me as the changes look more or less similar to Optional node.
@dselman One question - what is the semantic difference between Conditonal and Optional? They look like they exist for the same purpose.
Contributor
|
@K-Kumar-01 Ready for merge? |
Collaborator
Author
|
@algomaster99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: k-kumar-01 kushalkumargupta4@gmail.com
Add the transformer
OOXML<->CiceroMarkforconditional.Changes
Author Checklist
--signoffoption of git commit.masterfromfork:branchname