refactor(markdown-docx): remove return variable frequency api#429
Merged
dselman merged 1 commit intoalgoo-ooxmlfrom Jul 23, 2021
Merged
refactor(markdown-docx): remove return variable frequency api#429dselman merged 1 commit intoalgoo-ooxmlfrom
dselman merged 1 commit intoalgoo-ooxmlfrom
Conversation
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
Contributor
|
@K-Kumar-01 Open a bug report related to this. The title can be "Insertion of clauses with same variable names". You can mention a suggested solution too - pass a counter object to the This is the same problem @dselman and I discussed during the meeting so that's why I have mentioned the issue succinctly. Let me know if you need me to elaborate. |
K-Kumar-01
added a commit
that referenced
this pull request
Jul 26, 2021
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: k-kumar-01 kushalkumargupta4@gmail.com
Removes the return of
countervariable when converting toOOXML.Raised as a part of the discussion here
Changes
ooxmlas string intoOOXMLof theToOOXMLVisitor.jsAuthor Checklist
--signoffoption of git commit.masterfromfork:branchname