Skip to content

refactor(markdown-docx): remove return variable frequency api#429

Merged
dselman merged 1 commit intoalgoo-ooxmlfrom
k-kumar-01/remove-variable-frequency-api
Jul 23, 2021
Merged

refactor(markdown-docx): remove return variable frequency api#429
dselman merged 1 commit intoalgoo-ooxmlfrom
k-kumar-01/remove-variable-frequency-api

Conversation

@K-Kumar-01
Copy link
Copy Markdown
Collaborator

Signed-off-by: k-kumar-01 kushalkumargupta4@gmail.com

Removes the return of counter variable when converting to OOXML.
Raised as a part of the discussion here

Changes

  • Return only ooxml as string in toOOXML of the ToOOXMLVisitor.js

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@K-Kumar-01 K-Kumar-01 requested a review from algomaster99 July 23, 2021 11:14
Copy link
Copy Markdown
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo!

@dselman dselman merged commit 0a3d370 into algoo-ooxml Jul 23, 2021
@algomaster99 algomaster99 deleted the k-kumar-01/remove-variable-frequency-api branch July 23, 2021 16:09
@algomaster99
Copy link
Copy Markdown
Contributor

@K-Kumar-01 Open a bug report related to this. The title can be "Insertion of clauses with same variable names". You can mention a suggested solution too - pass a counter object to the OOXMLTransformer.

This is the same problem @dselman and I discussed during the meeting so that's why I have mentioned the issue succinctly. Let me know if you need me to elaborate.

K-Kumar-01 added a commit that referenced this pull request Jul 26, 2021
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants