refactor(markdown-docx): merge methods for roundtripping conversion between OOXML and CiceroMark into one class - OOXMLTransformer#425
Merged
algomaster99 merged 3 commits intoalgoo-ooxmlfrom Jul 6, 2021
Conversation
Create toOOXML() in OOXMLTransformer Update imports and exports Fix spellings Signed-off-by: K-Kumar-01 <kushalkumargupta4@gmail.com>
algomaster99
suggested changes
Jul 5, 2021
Contributor
algomaster99
left a comment
algomaster99
left a comment
There was a problem hiding this comment.
If you see the other transformers, this refactoring won't make it analogous to them. There should be OoxmlTransformer with two static methods - toCiceroMark and toOoxml. The former method should invoke the ToCiceroMarkVisitor while the latter should invoke the ToOoxmlStringVisitor. markdown-html is exactly structured like this so you can do the same for markdown-docx too.
K-Kumar-01
force-pushed
the
k-kumar-01/refactor-transformers-into-single-transformer
branch
from
09b4379 to
36c3b59
Compare
Signed-off-by: K-Kumar-01 <kushalkumargupta4@gmail.com>
K-Kumar-01
force-pushed
the
k-kumar-01/refactor-transformers-into-single-transformer
branch
from
36c3b59 to
b844c45
Compare
Signed-off-by: K-Kumar-01 <kushalkumargupta4@gmail.com>
algomaster99
changed the title
OOXMLTransformer
algomaster99
deleted the
k-kumar-01/refactor-transformers-into-single-transformer
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: K-Kumar-01 kushalkumargupta4@gmail.com
Need for the Change
To make the codebase consistent with the rest i.e. add
A<->Bconversion methods in the same transformer.Changes
Author Checklist
--signoffoption of git commit.masterfromfork:branchname