feat(markdown-docx): add API to return frequency of variables in CiceroMark (JSON) - #397#411
Merged
algomaster99 merged 2 commits intoalgoo-ooxmlfrom Jun 17, 2021
Conversation
Return counter for variables in CiceroMark Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
algomaster99
suggested changes
Jun 17, 2021
| } | ||
|
|
||
| /** | ||
| * Returns the counter holding variable counts for a CiceroMark. |
| this.getNodes(node, counter); | ||
| }); | ||
| this.globalOOXML = wrapAroundDefaultDocxTags(this.globalOOXML); | ||
| this.counter = counter; |
Contributor
There was a problem hiding this comment.
Since counter is an instance variable now, you don't need to maintain a separate counter. Use this.counter wherever required.
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
algomaster99
approved these changes
Jun 17, 2021
Contributor
algomaster99
left a comment
algomaster99
left a comment
There was a problem hiding this comment.
Nice work 🎉
Not sure if you noticed but ooxml = '' is also not needed in toOOXML. Maybe you can change it similarly in separate PR.
algomaster99
changed the title
algomaster99
deleted the
k-kumar-01/i397/return-counter-CiceromarkToOOXMLTransformer
branch
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return counter for variables in CiceroMark
Signed-off-by: k-kumar-01 kushalkumargupta4@gmail.com
Enhancement to the
CiceroMarkToOOXMLTransformerby returning the counter for variables in CiceroMark of a template.Changes
counterto store the counter.getCounter()that returns the counter.Related Issues
Raised as a part of the above PR.
Author Checklist
--signoffoption of git commit.masterfromfork:branchname