Skip to content

chore(markdown-docx): update eslint ecmaVersion#409

Merged
algomaster99 merged 1 commit intoalgoo-ooxmlfrom
k-kumar-01/eslint-change-ecmaVersion
Jun 16, 2021
Merged

chore(markdown-docx): update eslint ecmaVersion#409
algomaster99 merged 1 commit intoalgoo-ooxmlfrom
k-kumar-01/eslint-change-ecmaVersion

Conversation

@K-Kumar-01
Copy link
Copy Markdown
Collaborator

Signed-off-by: k-kumar-01 kushalkumargupta4@gmail.com

Changes the ecmaVersion to allow eslint to parse spread operator.

Changes

  • Change ecmaVersion to 2018

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@K-Kumar-01 K-Kumar-01 requested a review from algomaster99 June 16, 2021 10:32
Copy link
Copy Markdown
Contributor

@algomaster99 algomaster99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@algomaster99 algomaster99 changed the title chore(markdown-docx): change eslint ecmaVersion chore(markdown-docx): update eslint ecmaVersion Jun 16, 2021
@algomaster99 algomaster99 merged commit 5c6cf43 into algoo-ooxml Jun 16, 2021
@algomaster99 algomaster99 deleted the k-kumar-01/eslint-change-ecmaVersion branch June 16, 2021 10:53
algomaster99 pushed a commit that referenced this pull request Jun 17, 2021
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
algomaster99 pushed a commit that referenced this pull request Jun 17, 2021
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants