refactor: roundtrip test logic - #407#408
Merged
algomaster99 merged 3 commits intoalgoo-ooxmlfrom Jun 14, 2021
Merged
Conversation
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
algomaster99
suggested changes
Jun 14, 2021
Contributor
algomaster99
left a comment
algomaster99
left a comment
There was a problem hiding this comment.
This is a good start. But I think it can be refactored further. For example, you're still hardcoding the filename of your test data. Maybe you can avoid that. What you can probably do is use fs module to iterate over the files in the directory and run your test function over them. Once you do this, you won't have to edit your test files a lot and you will be done just by adding a test case for each node you write the transformations.
Read files from directory Run test for each read file Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
Collaborator
Author
|
@algomaster99 |
algomaster99
suggested changes
Jun 14, 2021
Contributor
algomaster99
left a comment
algomaster99
left a comment
There was a problem hiding this comment.
Minor change. Then we are good to go.
Collaborator
Author
|
@algomaster99 |
algomaster99
suggested changes
Jun 14, 2021
Test inequality hardcore file name Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
algomaster99
approved these changes
Jun 14, 2021
algomaster99
pushed a commit
that referenced
this pull request
Jun 17, 2021
* refactor: roundtrip test logic - #407 Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com> * refactor: roundtrip test logic - #407 Read files from directory Run test for each read file Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com> * refactor: roundtrip test logic - #407 Test inequality hardcore file name Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
algomaster99
pushed a commit
that referenced
this pull request
Jun 17, 2021
* refactor: roundtrip test logic - #407 Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com> * refactor: roundtrip test logic - #407 Read files from directory Run test for each read file Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com> * refactor: roundtrip test logic - #407 Test inequality hardcore file name Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: k-kumar-01 kushalkumargupta4@gmail.com
Closes #407
Refactors the test logic in
CiceroMarkToOOXMLRoundTrip.test.jsChanges
Author Checklist
--signoffoption of git commit.masterfromfork:branchname