Skip to content

chore(markdown-docx): use mocha instead of jest - #403#406

Merged
algomaster99 merged 4 commits intoalgoo-ooxmlfrom
k-kumar-01/i403/mocha-jest-markdown-docx
Jun 13, 2021
Merged

chore(markdown-docx): use mocha instead of jest - #403#406
algomaster99 merged 4 commits intoalgoo-ooxmlfrom
k-kumar-01/i403/mocha-jest-markdown-docx

Conversation

@K-Kumar-01
Copy link
Copy Markdown
Collaborator

@K-Kumar-01 K-Kumar-01 commented Jun 12, 2021

Signed-off-by: k-kumar-01 kushalkumargupta4@gmail.com

Closes #403

Uses mocha for testing instead of jest

Changes

  • Use mocha for testing instead of jest
  • Move test files in test directory

Flags

  • Skips the test in DocxTransformer.test.js.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

@K-Kumar-01
chore(markdown-docx): use mocha instead of jest - #403
472347b 
Use mocha for testing instead of jest
Move test files in test directory

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@K-Kumar-01 K-Kumar-01 requested a review from algomaster99 June 12, 2021 18:36
@K-Kumar-01
Copy link
Copy Markdown
Collaborator Author

K-Kumar-01 commented Jun 12, 2021

@algomaster99
Requesting your review.

algomaster99
algomaster99 suggested changes Jun 12, 2021
View reviewed changes
Comment thread packages/markdown-docx/package.json Outdated
Comment thread packages/markdown-docx/package.json
Comment thread packages/markdown-docx/test/RoundTrip.test.js
@algomaster99
Copy link
Copy Markdown
Contributor

algomaster99 commented Jun 12, 2021

Do look out for the build failures and try to debug them on your own.

@K-Kumar-01
Copy link
Copy Markdown
Collaborator Author

K-Kumar-01 commented Jun 12, 2021

Do look out for the build failures and try to debug them on your own.

@algomaster99
It can possibly be due to coverage reasons as far as I am understanding from the error.

@algomaster99
Copy link
Copy Markdown
Contributor

algomaster99 commented Jun 12, 2021

It can possibly be due to coverage reasons as far as I am understanding from the error.

Try debugging it on your own :)

@K-Kumar-01
chore(markdown-docx): change coverage script - #403
04e53a9 
Rename file RoundTrip.test.js
Remove CiceroMarkToOOXML/index.test.js

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@K-Kumar-01 K-Kumar-01 requested a review from algomaster99 June 12, 2021 19:23
algomaster99
algomaster99 suggested changes Jun 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@algomaster99 algomaster99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes then we are good to go.

Comment thread packages/markdown-docx/package.json
Comment thread packages/markdown-docx/test/DocxTransformer.test.js
@K-Kumar-01
chore: remove jest package and file - #403
a8f3401 
Remove jest package
Remove jest snapshots
Remove jest config

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@K-Kumar-01 K-Kumar-01 requested a review from algomaster99 June 13, 2021 10:44
algomaster99
algomaster99 suggested changes Jun 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@algomaster99 algomaster99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markdown-docx/package-lock.json should not be created if you use lerna. The packages in this repository are centrally managed by markdown-transform/package-lock.json.

@K-Kumar-01
chore: remove package-lock.json - #403
50c96aa 
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@K-Kumar-01
Copy link
Copy Markdown
Collaborator Author

K-Kumar-01 commented Jun 13, 2021

@algomaster99
I have deleted the package-lock.json. Let me know if there are any changes required.

@K-Kumar-01 K-Kumar-01 requested a review from algomaster99 June 13, 2021 12:44
algomaster99
algomaster99 approved these changes Jun 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@algomaster99 algomaster99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@algomaster99 algomaster99 merged commit e61f29a into algoo-ooxml Jun 13, 2021
@algomaster99 algomaster99 deleted the k-kumar-01/i403/mocha-jest-markdown-docx branch June 13, 2021 13:50
algomaster99 pushed a commit that referenced this pull request Jun 17, 2021
@K-Kumar-01 @algomaster99
chore(markdown-docx): use mocha instead of jest - #403 (#406)
34f5930 
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
algomaster99 pushed a commit that referenced this pull request Jun 17, 2021
@K-Kumar-01 @algomaster99
chore(markdown-docx): use mocha instead of jest - #403 (#406)
44b442a 
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@algomaster99 algomaster99 algomaster99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@K-Kumar-01 @algomaster99