Skip to content

Doc 319 - remove bleed and broken #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marklewin merged 4 commits into from
May 14, 2021
Merged

Doc 319 - remove bleed and broken #1093

marklewin merged 4 commits into from
May 14, 2021

Conversation

@tbedford
Copy link
Contributor

@tbedford tbedford commented May 14, 2021 •
edited
Loading

Description

  • Terms like "bleeding edge" and "broken down" are not necessary.
  • Where necessary changed "bleeding edge" to preview.
  • Removed broken down, or where needed used "organized".

Review

  • Page to review - carefully check the wording in the pop-up dialog
  • You'll also need to check the diff

@tbedford tbedford self-assigned this May 14, 2021
@mattheworiordan mattheworiordan temporarily deployed to ably-docs-pr-1093 May 14, 2021 10:37 Inactive
@tbedford tbedford temporarily deployed to ably-docs-pr-1093 May 14, 2021 10:45 Inactive
@tbedford tbedford temporarily deployed to ably-docs-pr-1093 May 14, 2021 10:48 Inactive
@tbedford tbedford temporarily deployed to ably-docs-pr-1093 May 14, 2021 12:52 Inactive
@tbedford tbedford marked this pull request as ready for review May 14, 2021 13:12
@tbedford tbedford requested a review from marklewin May 14, 2021 13:12
marklewin
marklewin approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@marklewin marklewin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked popup, viewed diff. Also searched for other instances and none found ... looks good!

@marklewin marklewin merged commit 8717b7e into main May 14, 2021
@marklewin marklewin deleted the doc-319-remove-bleed-broken branch May 14, 2021 16:42
mattheworiordan added a commit that referenced this pull request Jan 15, 2026
@mattheworiordan @claude
poc: T009 Sandpack SSR Compatibility
7a9bcc7 
Validates RFC hypothesis: "Sandpack works correctly with Next.js 15 App
Router without SSR errors or hydration mismatches."

Results:
- SSR Build: Passes without errors
- Hydration: No warnings in browser console
- Code Editor: Renders and is editable
- Preview Panel: Shows live output
- Refresh Button: Works correctly
- Bundle Size: 216 kB for Sandpack page

No workarounds required - standard 'use client' directive is sufficient.
GitHub issue #1093 appears resolved in Sandpack 2.20.0.

Key findings documented in POC_RESULTS.md.

Part of WEBRFC-005 Web Platform Technical Strategy validation.
https://ably.atlassian.net/wiki/spaces/Web/pages/4681039885/WEBRFC-005

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@mattheworiordan mattheworiordan mentioned this pull request Jan 15, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marklewin marklewin marklewin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tbedford tbedford

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tbedford @marklewin @mattheworiordan