Conversation
bugfix for wrong userInfo
fatfatson
changed the title
a7ul
left a comment
a7ul
left a comment
There was a problem hiding this comment.
Other than the changes mentioned. it looks good to me.
| RCT_EXPORT_MODULE(); | ||
|
|
||
| // METHOD TO INITIALIZE THE EXCEPTION HANDLER AND SET THE JS CALLBACK BLOCK | ||
| RCT_EXPORT_METHOD(raiseTestNativeError) { NSLog(@"RAISING A TEST EXCEPTION"); [NSException raise:@"TEST EXCEPTION" format:@"THIS IS A TEST EXCEPTION"]; } |
There was a problem hiding this comment.
As mentioned on the issue before . I dont think we should add raiseTestNative Error as part of this module. Could you please remove these.
| } | ||
| } | ||
|
|
||
| long letMeCrash(){ |
There was a problem hiding this comment.
Also please remove these test functions as well.
There was a problem hiding this comment.
ok, I have opened a new PR.
I had thought that only the commits before opening are visible, so I commit my own modify after open it, but it's not the truth. now I make a special branch for this, hope it's ok this time~
There was a problem hiding this comment.
by the way , except those test functions, getting and saving the slide is useful for symbol address translation, would you like it to be merged?
There was a problem hiding this comment.
Yes. I want to merge everything except the test functions
There was a problem hiding this comment.
Please remove only the test functions.
|
@fatfatson Can you include all the changes in one pr and close the rest ? |
2 participants
bugfix for wrong userInfo