chore: merge main into 1.0-dev

[ishymko]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request merges recent changes from the main branch into the 1.0-dev branch, primarily enhancing the asynchronous event processing pipeline. It introduces a robust mechanism for managing long-running background tasks initiated during event consumption, ensuring their proper lifecycle. Additionally, the agent's setup has been made more flexible by allowing the injection of its task storage component, which simplifies testing and future extensibility.

Highlights

• Background Task Tracking: The consume_and_break_on_interrupt method in ResultAggregator now explicitly returns an asyncio.Task when event stream consumption is interrupted and continues in the background, allowing callers to track and manage these tasks.
• Dependency Injection for TaskStore: The sut_agent.py entry point has been refactored to make the TaskStore injectable, improving modularity and testability.
• Pydantic Default Handling: Default initializations for mutable fields (state, user) in ServerCallContext were updated to use default_factory to prevent unintended shared state across instances.

Changelog

• src/a2a/server/context.py
  • Updated state and user fields to use default_factory for proper mutable default handling.
• src/a2a/server/request_handlers/default_request_handler.py
  • Modified push_notification_callback to correctly handle and track the new background task returned by consume_and_break_on_interrupt.
• src/a2a/server/tasks/result_aggregator.py
  • Modified the consume_and_break_on_interrupt method to return an asyncio.Task | None representing a background consumption task.
  • Updated docstrings to clarify the new return value and the caller's responsibility for tracking the background task.
  • Implemented the logic to create and return the background task when consumption is interrupted.
• tck/sut_agent.py
  • Imported the TaskStore interface.
  • Renamed the main function to serve and refactored it to accept a TaskStore instance as an argument.
  • Re-introduced a main function that serves as the entry point, calling serve with a default InMemoryTaskStore.
• tests/server/request_handlers/test_default_request_handler.py
  • Adjusted various test cases to accommodate the updated three-element return tuple from consume_and_break_on_interrupt.
  • Added assertions for the presence or absence of the background task in the return value.
• tests/server/request_handlers/test_jsonrpc_handler.py
  • Modified test patches for ResultAggregator.consume_and_break_on_interrupt to include None as the third element in its return value, matching the updated signature.
• tests/server/tasks/test_result_aggregator.py
  • Updated unit tests to verify the new bg_task return value from consume_and_break_on_interrupt.
  • Added assertions to check if the background task is None or not None as expected in different scenarios.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/python-publish.yml
• Ignored by pattern: CHANGELOG.md (1)
  • CHANGELOG.md

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several improvements, most notably refactoring the handling of background asyncio tasks to ensure they are not prematurely garbage collected. The consume_and_break_on_interrupt function now correctly returns the created background task, making the caller responsible for tracking it. This change enhances the application's robustness. Other changes include fixing the use of mutable default arguments in a Pydantic model and refactoring for better testability. The accompanying test updates are thorough and align with the code changes. The overall quality of the changes is high, and I did not find any issues to report.