fix: taskslist error on invalid page token and response serialization#814
Open
guglielmo-san wants to merge 2 commits intoa2aproject:1.0-devfrom
Open
fix: taskslist error on invalid page token and response serialization#814guglielmo-san wants to merge 2 commits intoa2aproject:1.0-devfrom
guglielmo-san wants to merge 2 commits intoa2aproject:1.0-devfrom
Conversation
…msError` and ensure all fields are printed in JSON RPC list task responses.
guglielmo-san
changed the title
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the summary. Please try again in a few hours by commenting |
ishymko
approved these changes
Mar 11, 2026
Comment on lines
+376
to
+380
| result = MessageToDict( | ||
| response, | ||
| preserving_proto_field_name=False, | ||
| always_print_fields_with_no_presence=True, | ||
| ) |
Member
There was a problem hiding this comment.
Can we have a test asserting the full payload to see exactly what's there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two main issues related to the list_tasks JSON-RPC endpoint: