fix: client should not specify taskId if it doesn't exist#264
Merged
holtskinner merged 6 commits intoa2aproject:mainfrom Jul 21, 2025
Merged
fix: client should not specify taskId if it doesn't exist#264holtskinner merged 6 commits intoa2aproject:mainfrom
taskId if it doesn't exist#264holtskinner merged 6 commits intoa2aproject:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm submitting this PR as a proposal based off of #218 (comment).
If the taskId doesn't exist, I was thinking that an exception should be thrown to prevent the client from specifying the id. The reason I think this change is required because if the client specifies a taskId but one doesnt exist, it won't actually get push notifications based off that first request, because the logic to
set_info()gets skipped because there is notaskwhen _setup_message_execution is called.Found while working on mozilla-ai/any-agent#414
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.nox -s formatfrom the repository root to format)Fixes #<issue_number_goes_here> 🦕