Skip to content

fix: client should not specify taskId if it doesn't exist#264

Merged
holtskinner merged 6 commits intoa2aproject:mainfrom
njbrake:patch-1
Jul 21, 2025
Merged

fix: client should not specify taskId if it doesn't exist#264
holtskinner merged 6 commits intoa2aproject:mainfrom
njbrake:patch-1

Conversation

@njbrake
Copy link
Contributor

@njbrake njbrake commented Jul 1, 2025

Description

I'm submitting this PR as a proposal based off of #218 (comment).

If the taskId doesn't exist, I was thinking that an exception should be thrown to prevent the client from specifying the id. The reason I think this change is required because if the client specifies a taskId but one doesnt exist, it won't actually get push notifications based off that first request, because the logic to set_info() gets skipped because there is no task when _setup_message_execution is called.

Found while working on mozilla-ai/any-agent#414

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants