Update to zig master, move uf2 and regz to monorepo#178
Conversation
|
Before merging, we have to branch into a zig-0.11.0 branch which i will backport as long as feasible |
|
Also can we incorporate the |
|
@MasterQ32 need some advice on how we want to deal with a breakage: It looks like |
I guess @andrewrk should take a look at this here. Sounds like a bug in Zig, but might also be by design.
But i'd be fine with this. |
ikskuh
left a comment
There was a problem hiding this comment.
Really quick review, didn't go through the big changes. Example usage on RP2040 looks fine so far, and this is the most important part of the whole project anyways
| .paths = .{ | ||
| "README.md", | ||
| "build.zig", | ||
| "build.zig.zon", | ||
| "LICENSE", | ||
| }, |
There was a problem hiding this comment.
This is missing the src/generate_linkerscript.zig file, README.md does not exist, LICENCE is missing.
I guess we should perform a final cleanup in the end, and also only package files present in .paths to the website?
|
|
||
| const available_examples = [_]Example{ | ||
| // RaspberryPi Boards: | ||
| .{ .target = rp2040.boards.raspberrypi.pico, .name = "pico_adc", .file = "src/adc.zig" }, |
There was a problem hiding this comment.
I'm fine with that change back to what we had before, but i'd add a generic function to add findTarget back somehow.
We don't have to expose it as the primary interface, but it makes things easier if we want to pass the target device from the outside
|
Re: std_options changing to a struct instance: Actually I like this change, it was pretty easy to do the same for interrupts and it improves discoverability as zls completions help let the user know what interrupts they can define. In addition, turning of building of examples for AVR for now. I see the following issue: |
Yeah that might be reasonable. I think we should focus on the refactor, then start fixing the AVR stuff
That looks like someone assumed overaligned types :D Afaik, AVR allows everything to be
Hell, yeah! |
|
in case this hasnt been said anywhere the alignment assertion problem is ziglang/zig#19665 |
No description provided.