Skip to content
This repository was archived by the owner on Oct 4, 2022. It is now read-only.

Comments

Use the set date instead of getDate()#1131

Merged
hansjovis merged 1 commit intodevelopfrom
P2-699-fix-date-selection-bug
Mar 30, 2021
Merged

Use the set date instead of getDate()#1131
hansjovis merged 1 commit intodevelopfrom
P2-699-fix-date-selection-bug

Conversation

@andizer
Copy link
Contributor

@andizer andizer commented Mar 30, 2021

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/schema-blocks] Fixes a bug where todays date will be shown always no matter which date is chosen.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

  • Add a job posting
  • Select a date for the closes on block
  • See that the value is the date that has been selected.

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    *

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@andizer andizer added changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation labels Mar 30, 2021
@hansjovis
Copy link
Contributor

Acceptance: ✅

@hansjovis hansjovis merged commit 5fe67a9 into develop Mar 30, 2021
@hansjovis hansjovis deleted the P2-699-fix-date-selection-bug branch March 30, 2021 08:37
@increddibelly increddibelly added this to the 16.2 milestone Apr 6, 2021
@johannadevos johannadevos added changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog and removed changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog innovation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants