[Issue-578] - adjust AuthOptionsResponse parser decode#590
Closed
anettodev wants to merge 2 commits intoXcodesOrg:mainfrom
Closed
[Issue-578] - adjust AuthOptionsResponse parser decode#590anettodev wants to merge 2 commits intoXcodesOrg:mainfrom
anettodev wants to merge 2 commits intoXcodesOrg:mainfrom
Conversation
Author
|
If someone can provide a better doc about Already checked the |
Contributor
|
@anettodev support for authentication keys have been added in #617 so I'm going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user has a 2FA with security keys (yubikey), the AuthOptionsResponse cannot be parsed because
securityCodeattribute is not optional and theAuthenticationError.accountUsesUnknownAuthenticationKindis never shown.The correct authType for security keys is not implemented and needs to check more the documentation for this.
PS: also, I have updated some missing pt-br localization strings @MattKiazyk
Before:
After
