Fix broken DockProgress Bar#545
Merged
MattKiazyk merged 2 commits intoXcodesOrg:mainfrom Jun 28, 2024
Merged
Conversation
This was referenced Mar 30, 2024
Update DockProgress and adopt the new Concurrency Model
Contributor
Contributor
Author
When I test my PR locally, I'll always hit helperInstallState != .installed. That may explain why it didn't fix the issue for you. After reviewing your change, it looks fine and I was wondering should we remove Line 432 on AppState+Install.swift after your change. @MattKiazyk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #529 and #491