Skip to content

Improve signing experience when using non-english keyboard #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MattKiazyk merged 1 commit into from
Mar 8, 2024
Merged

Improve signing experience when using non-english keyboard #521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Xcodes/Frontend/SignIn/SignInCredentialsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
import SwiftUI

struct SignInCredentialsView: View {
private enum FocusedField {
case username, password
}

@EnvironmentObject var appState: AppState
@State private var username: String = ""
@State private var password: String = ""
@FocusState private var focusedField: FocusedField?

var body: some View {
VStack(alignment: .leading) {
Expand All @@ -16,11 +21,13 @@ struct SignInCredentialsView: View {
TextField(text: $username) {
Text(verbatim: "example@icloud.com")
}
.focused($focusedField, equals: .username)
}
HStack {
Text("Password")
.frame(minWidth: 100, alignment: .trailing)
SecureField("Required", text: $password)
.focused($focusedField, equals: .password)
}
if appState.authError != nil {
HStack {
Expand Down